Skip to content

Conversation

amsanghi
Copy link
Contributor

Fixes: NIT-3986

@amsanghi amsanghi marked this pull request as ready for review October 16, 2025 11:20
@amsanghi amsanghi requested a review from eljobe October 16, 2025 11:25
Copy link

github-actions bot commented Oct 16, 2025

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
2143 5 2138 0
View the top 3 failed tests by shortest run time
TestBroadcastClientConfirmedMessage
Stack Traces | 5.010s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [10-16|11:49:57.223] arbitrum websocket broadcast server is listening address=[::]:39119
INFO [10-16|11:49:57.223] arbitrum websocket broadcast server is listening address=[::]:36979
INFO [10-16|11:49:57.225] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:39119/
INFO [10-16|11:49:57.225] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:36979/
INFO [10-16|11:49:57.225] arbitrum websocket broadcast server is listening address=[::]:41409
INFO [10-16|11:49:57.225] arbitrum websocket broadcast server is listening address=[::]:32927
    broadcastclient_test.go:387: broadcasting seq 0 message
INFO [10-16|11:49:57.226] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:41409/
INFO [10-16|11:49:57.227] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:32927/
INFO [10-16|11:49:57.227] Feed connected                           feedServerVersion=2 chainId=9742 requestedSeqNum=0
INFO [10-16|11:49:57.227] Feed connected                           feedServerVersion=2 chainId=8742 requestedSeqNum=0
INFO [10-16|11:49:57.227] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:41409/
INFO [10-16|11:49:57.229] Feed connected                           feedServerVersion=2 chainId=8742 requestedSeqNum=0
INFO [10-16|11:49:57.229] Feed connected                           feedServerVersion=2 chainId=8744 requestedSeqNum=0
INFO [10-16|11:49:57.230] Feed connected                           feedServerVersion=2 chainId=8744 requestedSeqNum=0
ERROR[10-16|11:49:57.231] error validating feed signature          error="signature not verified: signer not approved" "sequence number"=0
    broadcastclient_test.go:397: Received Message, Sequence Message: {0 {0xc0002c67e0 0} <nil> [59 158 230 244 210 159 187 44 213 144 3 33 106 31 34 19 238 94 58 178 204 138 201 193 99 79 150 196 112 221 78 24 30 45 60 5 21 176 255 131 98 231 186 71 238 96 60 160 38 220 131 134 227 86 185 131 238 114 4 116 150 40 103 59 1] [] 0}
WARN [10-16|11:49:57.232] confirmed sequence number is past the end of stored messages "confirmed sequence number"=42 "last stored sequence number"=0
    broadcastclient_test.go:418: Client did not receive confirm message
--- FAIL: TestBroadcastClientConfirmedMessage (5.01s)
TestVersion30
Stack Traces | 6.510s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== PAUSE TestVersion30
=== CONT  TestVersion30
    precompile_inclusion_test.go:90: goroutine 454864 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x4082650, 0xc08ed12380}, {0x4040880, 0xc1212796e0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc08ed12380, {0x4040880, 0xc1212796e0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc08ed12380, 0x1e, {0xc0af975db0, 0x6, 0x6000000000070?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc08ed12380?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc08ed12380, 0x3ccab80)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
�[90m--- FAIL: TestVersion30 (6.51s)
TestVersion40
Stack Traces | 6.590s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== CONT  TestVersion40
ERROR[10-16|12:01:43.626] Dangling trie nodes after full cleanup
    precompile_inclusion_test.go:90: goroutine 454865 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x4082650, 0xc08ed12540}, {0x4040880, 0xc1212794d0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc08ed12540, {0x4040880, 0xc1212794d0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc08ed12540, 0x28, {0xc102681df8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc08ed12540?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc08ed12540, 0x3ccab88)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (6.59s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants